Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apache httpclient version #1446

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Remove apache httpclient version #1446

merged 2 commits into from
Oct 22, 2020

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Oct 21, 2020 •
edited

This is reponed PR #1432. There was problems with CLA.

What is in this PR?

  1. Versions are removed from instrumentation names
  2. Add instrumentation name to spring-web (was null before)

Fixes #1260

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 21, 2020 •
edited

CLA Check
The committers are authorized under a signed CLA.

@vadeg vadeg changed the title Gh 1260 remove apache httpclient version Remove apache httpclient version Oct 21, 2020
trask
trask approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vadeg!

...common/src/main/java/io/opentelemetry/javaagent/instrumentation/mongo/MongoClientTracer.java
@@ -24,7 +24,6 @@
public class MongoClientTracer extends DatabaseClientTracer<CommandStartedEvent, BsonDocument> {
public static final MongoClientTracer TRACER = new MongoClientTracer();

// TODO use tracer names *.mongo-3.1, *.mongo-3.7, *.mongo-async-3.3 respectively in each module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

anuraaga
anuraaga approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anuraaga anuraaga merged commit 9e8d663 into open-telemetry:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should instrumentation version for instrumentations be changed to something more descriptive?
3 participants
@vadeg @anuraaga @trask