Replace print with log messages.
#1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadeg
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
* Add `slf4j` compile time dependency to the `javaagent-exporters.logging` module * Replace `System.out.println` with log.debug messages Fixes: open-telemetry#1328
vadeg
force-pushed
the
gh-1328-replace-sout-with-log
branch
from
be44e52
to
069397e
Compare
anuraaga
reviewed
Oct 21, 2020
...ters/logging/src/main/java/io/opentelemetry/javaagent/exporters/logging/LoggingExporter.java
Outdated
Show resolved
Hide resolved
...ters/logging/src/main/java/io/opentelemetry/javaagent/exporters/logging/LoggingExporter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
|
Updated with suggestions from @anuraaga |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
printwith log messages.slf4jcompile time dependency to thejavaagent-exporters.loggingmoduleSystem.out.printwithlog.debugmessagesConcerns:
log.debug. I can replace it if you think that it should be in other level.AttributeKeyls logged usingtoString()method from its implementation. The only implementation right now isAutoValue_AttributeKeyImplwhich prints the key like"AttributeKeyImpl{getType=" + this.getType + ", key=" + this.key + "}". I think it is not a good idea to usetoStringfrom objects for logging because anyone can change the method's implementation or provide implementation withouttoString(with default) and it will affect logging quality. I would change it not rely ontoStringoutput, but I don't know what would the appropriate format for this. If you have ideas please share.Fixes: #1328