Add explicit names to metrics/trace SPI factories #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
trask
approved these changes
Oct 28, 2020
javaagent-spi/src/main/java/io/opentelemetry/javaagent/spi/exporter/MetricServer.java
Show resolved
Hide resolved
javaagent-spi/src/main/java/io/opentelemetry/javaagent/spi/exporter/SpanExporterFactory.java
Show resolved
Hide resolved
iNikem
approved these changes
Oct 28, 2020
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/TracerInstaller.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
get-names-spi
branch
from
cf61c1c
to
b7b2176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay p.loffay@gmail.com
Resolves #1287
See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-environment-variables.md