Switch gRPC instrumentation to instrument public ServerBuilder class. #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
trask
reviewed
Dec 7, 2020
...a/io/opentelemetry/javaagent/instrumentation/grpc/v1_5/GrpcServerBuilderInstrumentation.java
Outdated
Show resolved
Hide resolved
anuraaga
force-pushed
the
grpc-latestdeps-fix
branch
from
690c4ed
to
e34e557
Compare
trask
approved these changes
Dec 7, 2020
iNikem
approved these changes
Dec 7, 2020
bhautikpip
pushed a commit
to bhautikpip/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 18, 2020
…open-telemetry#1839) * Switch gRPC instrumentation to instrument public ServerBuilder class. * A bit more readability (hopefully) * hack * Remove library dedupe for now since we need a better story.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have been harder if tracing server interceptor had to be at the beginning of the list, but since it doesn't, we can just instrument the public type without problem.
Fixes #1453