Instrument spring batch chunk #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
instrument-spring-batch-chunk
branch
6 times, most recently
from
45c007f
to
01125de
Compare
mateuszrzeszutek
force-pushed
the
instrument-spring-batch-chunk
branch
5 times, most recently
from
ba12145
to
5585abe
Compare
mateuszrzeszutek
force-pushed
the
instrument-spring-batch-chunk
branch
from
5585abe
to
3775030
Compare
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Dec 17, 2020
anuraaga
approved these changes
Dec 18, 2020
| String stepName = chunkContext.getStepContext().getStepName(); | ||
| SpanBuilder spanBuilder = | ||
| tracer.spanBuilder("BatchJob " + jobName + "." + stepName + ".Chunk").setSpanKind(INTERNAL); | ||
| if (shouldCreateRootSpanForChunk()) { |
There was a problem hiding this comment.
What's the use case for this flag by the way? It seems like it'd be nice if we can decide one or the other is better and stick with it
There was a problem hiding this comment.
That one's controversial, I know - Spring Batch jobs can get veeery large, like millions of spans in a trace. We are still in the middle of experimenting with how to treat traces like these, one option was to split them into many smaller traces. Personally, I don't think that having a separate trace for each chunk makes sense from a semantic perspective (since it's still a single job execution), but I added this here just to be able to experiment with this. It's highly probable that it'll get removed in one of the future PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1843, #1852