testing-common refactoring: replace direct AgentTestRunner usage with… #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
can you update https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/writing-instrumentation.md#writing-instrumentation-tests and the section below to reflect these changes?
I forgot about these docs, thanks! |
anuraaga
approved these changes
Jan 29, 2021
| @@ -91,8 +91,8 @@ After writing a test or two, go back to the `library` package, make sure it has | |||
| `testing` submodule and add a test that inherits from the abstract test class. You should implement | |||
| the method to initialize the client using the library's mechanism to register interceptors, perhaps | |||
| a method like `registerInterceptor` or wrapping the result of a library factory when delegating. The | |||
| test should implement the `InstrumentationTestRunner` trait for common setup logic. If the tests | |||
| pass, library instrumentation is working OK. | |||
| test should implement the `LibraryTestTrait` trait for common setup logic. If the tests pass, | |||
There was a problem hiding this comment.
These names are much better!
|
|
||
| static InstrumentationTestRunner instrumentationTestRunner | ||
| static InMemorySpanExporter testWriter | ||
|
|
||
| def setupSpec() { | ||
| void runnerSetupSpec() { |
There was a problem hiding this comment.
Ah yeah this workaround is even nicer
mateuszrzeszutek
force-pushed
the
testing-common-agent-test-runner
branch
from
6b94399
to
485db38
Compare
added 3 commits
January 29, 2021 13:26
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
mateuszrzeszutek
force-pushed
the
testing-common-agent-test-runner
branch
from
485db38
to
dac6492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… spock spec
Another part of #1644
I've replaced direct
AgentTestRunnerusages withAgentInstrumentationSpecification, which is based on @anuraaga'sInstrumentationSpecification& agent/library traits idea. The aim of this whole refactoring is to makeAgentTestRunner(and other crucial test code) Java-only - and thus usable in non-spock tests.This PR is pretty big but it's mostly imports & renaming things.