Disable retry on connection failure for okhttp3 tests #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Feb 1, 2021
trask
approved these changes
Feb 2, 2021
|
@laurit Can you update the PR description with the motivation of the change? I don't quite understand how connection retry is related to the issue linked. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2153
OkHttp3AsyncTestwaits for request to complete withlatch.await(30, SECONDS)if response or failure is not received in this time then the request will fail withNullPointerExceptionby reading response that it has not received yet.HttpClientTest "connection error dropped request"expects the request to fail, connection timeout is set to5s. Usually it completes in ~10s without retry it completes in~5s. Same test with okhttp2 does not retry the request and completes in5s.This PR removes retry from okhttp3 in the hopes that this makes test less flaky. I have seen this failure multiple times, but I have not seen a similar failure for okhttp2.