Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stability of jms-1.1 tests #2169

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Improve stability of jms-1.1 tests #2169

merged 1 commit into from
Feb 2, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 2, 2021

  • sort traces to be in expected order
  • increase timeout for starting activemq container

anuraaga
anuraaga approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@iNikem iNikem merged commit 4d59fc0 into open-telemetry:main Feb 2, 2021
@trask
Copy link
Member

trask commented Feb 4, 2021

nice ❤️

@laurit laurit deleted the jms-1.1-flaky branch February 4, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem iNikem approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@laurit @trask @anuraaga @iNikem @mateuszrzeszutek