New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stability of elasticsearch tests #2170

Merged

iNikem merged 1 commit into open-telemetry:main from laurit:elasticsearch-test-stability

Feb 2, 2021

Contributor

laurit commented Feb 2, 2021

Disables background job that creates spans not expected by tests. Currently failure can be forced by adding a sleep (I used 30s) before asserting traces.
shut down spring and elasticsearch in Elasticsearch53SpringRepositoryTest, without shutting it down it seems to interfere with other tests


          Imporve stability of elasticsearch tests

45e0261

laurit requested review from anuraaga, iNikem, jkwatson, mateuszrzeszutek, pavolloffay, trask and tylerbenson as code owners

February 2, 2021 10:00

mateuszrzeszutek approved these changes

View reviewed changes

anuraaga approved these changes

View reviewed changes

iNikem approved these changes

View reviewed changes

iNikem merged commit 89fd887 into open-telemetry:main

laurit deleted the elasticsearch-test-stability branch

February 4, 2021 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anuraaga anuraaga approved these changes

iNikem iNikem approved these changes

mateuszrzeszutek mateuszrzeszutek approved these changes

jkwatson Awaiting requested review from jkwatson

pavolloffay Awaiting requested review from pavolloffay

trask Awaiting requested review from trask

tylerbenson Awaiting requested review from tylerbenson