Auto-instrumentation for JaxWS #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovencij
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Feb 3, 2021
|
Please update README as well |
mateuszrzeszutek
approved these changes
Feb 3, 2021
| group = "javax.xml.ws" | ||
| module = "jaxws-api" | ||
| versions = "[2.0,]" | ||
| skipVersions += '2.1-1' // contains broken dependency |
There was a problem hiding this comment.
Does it make sense to add assertInverse = true?
There was a problem hiding this comment.
Not sure it is needed. The API is very stable, even version 2.0 is from 2006 or something. Current is 2.3. And I couldn't find 1.0. Then it all moved to jakarta and in November 2020 they released new versions of all java EE components (Java EE 9), where packages were changed to jakarta... instead of javax.... So all existing Java EE instrumentations will have to be revisited to support Java EE 9 with new package names...
anuraaga
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JaxWS is a set of APIs for SOAP WebServices. This PR adds auto-instrumentation for
@javax.jws.WebServiceannotation from Java Web Services Metadata (separate library, but jaxws assumes it is present) used to define a web-service,javax.xml.ws.Providerinterface from Jax WS API, alternative way of handling SOAP messages.