Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch: fix unexpected spans for ConnectException: Connection refused #2181

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Elasticsearch: fix unexpected spans for ConnectException: Connection refused #2181

merged 1 commit into from
Feb 4, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 3, 2021

  • Configure elasticsearch to run in a single node cluster. This skips discovery of other cluster nodes. Currently this discovery process doesn't always complete before tests start to run so tests may fail because there is an unexpected span for java.net.ConnectException: Connection refused
  • Shut down PreBuiltTransportClient to avoid it attempting to reconnect with a shut down node which can produce unexpected span for java.net.ConnectException: Connection refused in subsequent test

@richardstartin richardstartin mentioned this pull request Feb 3, 2021
Closed
@anuraaga anuraaga merged commit 7752235 into open-telemetry:main Feb 4, 2021
@trask
Copy link
Member

trask commented Feb 4, 2021

nice, thx!

@laurit laurit deleted the elasticsearch-connectexception branch February 4, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem iNikem approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@laurit @trask @anuraaga @iNikem @mateuszrzeszutek