Remove all remaining direct AgentTestRunner usages #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
reviewed
Feb 5, 2021
| */ | ||
| @SpecMetadata(filename = "AgentTestRunner.java", line = 0) | ||
| public abstract class AgentTestRunner extends Specification { | ||
| public final class AgentTestRunner { |
There was a problem hiding this comment.
Should it be public? If yes, then some javadoc is needed.
There was a problem hiding this comment.
Hmm, do you mind if I do it in the next PR? I planned to make AgentTestRunner and InstrumentationTestRunner implement a common interface, put them in the java source set (and in the next next PR introduce a JUnit base class/extension) -- anyway, I'll place some Javadoc in the next step, when I completely refactor this class.
iNikem
approved these changes
Feb 5, 2021
mateuszrzeszutek
deleted the
remove-all-remaining-direct-AgentTestRunner-usages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now everybody's forced to use
AgentInstrumentationSpecificationwhen testing agent instrumentations