Add constructors/methods to the base tracers to enable injecting an OpenTelemetry instance #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
requested review from
anuraaga,
iNikem,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
jkwatson
commented
Feb 4, 2021
| @@ -111,7 +110,7 @@ public HttpHost getTarget() { | |||
| @Override | |||
| public HttpRequest generateRequest() throws IOException, HttpException { | |||
| HttpRequest request = delegate.generateRequest(); | |||
| GlobalOpenTelemetry.getPropagators() | |||
| tracer().getPropagators() | |||
There was a problem hiding this comment.
I updated this particular instrumentation because I wanted to make sure that the basic idea was workable.
trask
approved these changes
Feb 4, 2021
...entation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/HttpClientTracer.java
Show resolved
Hide resolved
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/BaseTracer.java
Show resolved
Hide resolved
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/BaseTracer.java
Outdated
Show resolved
Hide resolved
jkwatson
commented
Feb 4, 2021
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/BaseTracer.java
Show resolved
Hide resolved
anuraaga
reviewed
Feb 5, 2021
| * Prefer to pass in an OpenTelemetry instance, rather than just a Tracer, so you don't have to | ||
| * use the GlobalOpenTelemetry Propagator instance. | ||
| * | ||
| * @deprecated prefer to pass in an OpenTelemetry instance, instead. |
There was a problem hiding this comment.
These artifacts aren't used much so not a big deal IMO, but as general practice, we'd link to the new method, @deprecated Use {@link #BaseTracer(OpenTelemetry)} instead
There was a problem hiding this comment.
that's a good idea. Happy to amend this PR, or follow-up later.
anuraaga
approved these changes
Feb 5, 2021
iNikem
approved these changes
Feb 5, 2021
mateuszrzeszutek
approved these changes
Feb 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't gone and updated any of the many other sub-tracers to inject the global, but having the capability means we can start migrating toward that model. This will enable the spring sleuth integration to not have to mess around with the global instance during startup.