Refactor AgentTestRunner: extract a common interface, convert to Java class #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Feb 8, 2021
testing-common/src/main/java/io/opentelemetry/instrumentation/testing/AgentTestRunner.java
Show resolved
Hide resolved
|
@mateuszrzeszutek By the way, if we can use, or have ideas for improving, https://github.com/open-telemetry/opentelemetry-java/tree/main/sdk/testing that'd be pretty sweet |
Those assertions are pretty nice, it would be great if we could reuse them in the instrumentation repo... ideally we should only have a thin groovy wrapper over them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traits got a lot smaller, all differences between agent and library instrumentation tests were moved to
InstrumentationTestRunner. Next part will introduce JUnit 5 extensions (or base classes, I'll see which one is less painful to use 😄 )