Add custom distro instrumentation unit test example #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
distro-test-exammple
branch
from
2ea13ed
to
847b119
Compare
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
|
|
iNikem
reviewed
Feb 25, 2021
| jvmArgs "-Dotel.threadPropagationDebugger=true" | ||
| jvmArgs "-Dotel.internal.failOnContextLeak=true" | ||
| // always print muzzle warnings | ||
| jvmArgs "-Dio.opentelemetry.javaagent.slf4j.simpleLogger.log.muzzleMatcher=warn" |
There was a problem hiding this comment.
@mateuszrzeszutek Doesn't this mean that only WARN and above will be logged from muzzle? Meaning the opposite of what you wanted? Also -Dotel.javaagent.debug=true should already tweak muzzle logging as needed.
There was a problem hiding this comment.
It only logs WARNs anyway. But you're right, this is completely not needed, otel.java.debug enables it anyway - I'll fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.