Add test matrix Docker images for OpenJ9 #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoallikmaa
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Feb 23, 2021
|
|
||
| WORKDIR $HOME_DIR | ||
|
|
||
| COPY app.war $DEPLOY_DIR |
There was a problem hiding this comment.
Move COPY line to the end of the file. Then static EXPOSE and CMD layers can be cached.
| COPY --from=default $SERVER_BASE $SERVER_BASE | ||
| WORKDIR $SERVER_BASE | ||
|
|
||
| COPY app.war $SERVER_BASE/webapps/ |
There was a problem hiding this comment.
Move COPY line to the end of the file. Then static EXPOSE and CMD layers can be cached.
mateuszrzeszutek
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added OpenJ9 test image creation for all existing appservers. These images have been tested to pass smoke tests locally, but that will be a separate PR because these images will only exist in the public repository after this is merged.
Changed the way that images are listed to be both more flexible (allows overriding Dockerfile name, and give custom build arguments per version/vm/jdk) and avoid VM name and version number duplication for matrix-like groups (without exclusions).