Move rest of non-specd attributes to experimental #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
iNikem
approved these changes
Feb 25, 2021
anuraaga
approved these changes
Feb 25, 2021
mateuszrzeszutek
approved these changes
Feb 25, 2021
Comment on lines
42
to
45
| private static final boolean CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES = | ||
| Config.get() | ||
| .getBooleanProperty( | ||
| "otel.instrumentation.apache-camel.experimental-span-attributes", false); |
There was a problem hiding this comment.
Hm, can you use the constant from BaseSpanDecorator if you make it protected?
There was a problem hiding this comment.
👍 will make this change (in this PR) tomorrow
|
@trask what's the problem with calling |
A couple possible solutions would be to init the default config with system properties for library instrumentation users, or to have an instrumentation-specific configuration API that library users (and the javaagent) can use to configure it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost completes #1874, except for aws-sdk-2.2, because we don't have solution for
Config.get()in library instrumentation yet.