Move SERVER and CLIENT span context keys out of BaseTracer #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
commented
Mar 2, 2021
Comment on lines
-48
to
-49
| // TODO(anuraaga): Should probably be renamed to local root key since it could be a consumer span | ||
| // or other non-server root. |
There was a problem hiding this comment.
I've removed this TODO because it's possible to have a CONSUMER->CONSUMER trace (in case of batch receiving).
|
Closing and re-opening to re-trigger CLA check |
trask
approved these changes
Mar 2, 2021
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/ClientSpan.java
Outdated
Show resolved
Hide resolved
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/ServerSpan.java
Outdated
Show resolved
Hide resolved
iNikem
approved these changes
Mar 3, 2021
| return context.get(KEY); | ||
| } | ||
|
|
||
| static Context with(Context context, Span clientSpan) { |
There was a problem hiding this comment.
I am not quite happy with this name. It seems like "client span with that context". Oh where are you, extension functions or infix operators!
But I don't have much better suggestions right now.
There was a problem hiding this comment.
Oh where are you, extension functions or infix operators!
We can't switch to Kotlin this late in the game, can we? 😄
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1726 (comment)