Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SDK - SNS to SQS tracing propagation test #2483

Merged
merged 3 commits into from Mar 4, 2021
Merged

AWS SDK - SNS to SQS tracing propagation test #2483

merged 3 commits into from Mar 4, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2021

  • adds test ensuring proper SNS to SQS trace context propagation for AWS SDK v1
  • test is ignored as localstack needs to implement X-Ray feature for SNS (PR filed)

anuraaga
anuraaga approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the help!

@ghost ghost closed this Mar 4, 2021
@ghost ghost reopened this Mar 4, 2021
@trask trask merged commit 9a5bc66 into open-telemetry:main Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anuraaga @iNikem @mateuszrzeszutek @trask @kuba-wu