Rename more properties #2486
Merged
Rename more properties #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Mar 4, 2021
| @@ -30,7 +30,7 @@ test.finalizedBy(tasks.register("testChunkRootSpan", Test) { | |||
| filter { | |||
| includeTestsMatching '*ChunkRootSpanTest' | |||
| } | |||
| jvmArgs '-Dotel.instrumentation.spring-batch.chunk.root-span=true' | |||
| jvmArgs '-Dotel.instrumentation.spring-batch.chunk.new-trace=true' | |||
There was a problem hiding this comment.
Strong +1 to new-trace always much more grokkable than talking about root spans.
There was a problem hiding this comment.
Should we add experimental to this property?
trask
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Mar 4, 2021
| @@ -22,9 +22,9 @@ | |||
| ContextKey.named("thread-propagation-locations"); | |||
|
|
|||
| private static final boolean THREAD_PROPAGATION_DEBUGGER = | |||
| Boolean.getBoolean("otel.threadPropagationDebugger"); | |||
| Boolean.getBoolean("otel.javaagent.experimental.thread-propagation-debugger.enabled"); | |||
There was a problem hiding this comment.
What do you think about otel.javaagent.debug.thread-propagation.enabled instead? We could also set its default value to Config.isAgentDebugEnabled()
mateuszrzeszutek
approved these changes
Mar 4, 2021
This was referenced Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
otel.exporter.jarandotel.initializer.jarexperimental because we are planning to replace withotel.javaagent.extensionssoon (#2442):otel.exporter.jar->otel.javaagent.experimental.exporter.jarotel.initializer.jar->otel.javaagent.experimental.initializer.jarPut all instrumentation settings that are not specific to one
[id]underotel.instrumentation.common.*:otel.instrumentation.default-enabled->otel.instrumentation.common.default-enabledFollow existing convention of using
.enabled:otel.instrumentation.kafka.client-propagation->otel.instrumentation.kafka.client-propagation.enabledRename to better name(?):
otel.instrumentation.spring-batch.chunk.root-span->otel.instrumentation.spring-batch.chunk.new-traceI think these are experimental(?):
otel.javaagent.runtime.context.field.injection->otel.javaagent.experimental.field-injection.enabledotel.threadPropagationDebugger->otel.javaagent.experimental.thread-propagation-debugger.enabledUse
otel.javaagent.testing.*for settings used during testing only:internal.testing.disable.global.library.ignores->otel.javaagent.testing.additional-library-ignores.enabled(and flipped)otel.internal.failOnContextLeak->otel.javaagent.testing.fail-on-context-leakotel.internal.enableTransformSafeLogging->otel.javaagent.testing.transform-safe-logging.enabledNote to self: I owe two follow-up PRs for this: