Apache Camel - S3 to SQS propagation impl + tests #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
Build failed, seems unrelated, rebased to check. |
|
@kubawach Please rebase again. Main branch failure was fixed |
anuraaga
approved these changes
Mar 17, 2021
...main/java/io/opentelemetry/javaagent/instrumentation/awssdk/v1_11/TracingRequestHandler.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Mar 18, 2021
mateuszrzeszutek
approved these changes
Mar 18, 2021
...nt/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/S3CamelTest.groovy
Outdated
Show resolved
Hide resolved
...nt/src/test/groovy/io/opentelemetry/javaagent/instrumentation/apachecamel/S3CamelTest.groovy
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
After all Camel - related PRs are merged I intend to file a separate clean-up one with uniform AWS communication, test setup (spring camel vs infra preparation) and span assertions (improving readability)