Fix JDBC instrumentation: recursive statements inside Connection#getMetaData

[mateuszrzeszutek]

Fixes #2644

The recursive Statement call happens before we start the CLIENT span (DbInfo dbInfo = extractDbInfo(connection)), so the shouldStartSpan() cannot prevent this - it's too late.

[trask]

can you add a test for prepared statement too? just because this feels fragile (and an important fix 👍)

[marcobjorge]

Hi @mateuszrzeszutek ,

With this fix if we have multi-layer JDBC driver we are never able to capture traces from the innermost layers (e.g. using Apache Calcite with underlying MySQL). Any ideias how we can work around it, even if as a workaround?

For example, could we do CallDepth.forClass(statement.getClass()); instead of CallDepth.forClass(Statement.class);?

Thanks,

[iNikem]

@marcobjorge can you please open a new issue for this? Otherwise it will be lost.