Sync spring-boot-autoconfigure property names with SDK property names #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
trask
force-pushed
the
spring-boot-autoconfigure-property-names
branch
from
94ba873
to
350ac3c
Compare
trask
force-pushed
the
spring-boot-autoconfigure-property-names
branch
from
350ac3c
to
b6433fd
Compare
iNikem
approved these changes
Apr 11, 2021
anuraaga
approved these changes
Apr 12, 2021
mateuszrzeszutek
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #864
Renames exporter properties to match SDK properties:
opentelemetry.trace.exporters.otlp.endpoint->otel.exporter.otlp.endpointopentelemetry.trace.exporters.otlp.spantimeout->otel.exporter.otlp.timeoutopentelemetry.trace.exporters.jaeger.endpoint->otel.exporter.jaeger.endpointopentelemetry.trace.exporters.jaeger.spantimeout->otel.exporter.jaeger.timeoutopentelemetry.trace.exporters.zipkin.endpoint->otel.exporter.zipkin.endpointRenames exporter enablement properties:
opentelemetry.trace.exporters.otlp.enabled->otel.exporter.otlp.enabledopentelemetry.trace.exporters.jaeger.enabled->otel.exporter.jaeger.enabledopentelemetry.trace.exporters.zipkin.enabled->otel.exporter.zipkin.enabledopentelemetry.trace.exporters.logging.enabled->otel.exporter.logging.enabledRenames sampling probability property:
opentelemetry.trace.tracer.samplerProbability->otel.traces.sampler.probability^^ this still does not match SDK property, which is
otel.traces.sampler.argRenames instrumentation enablement properties:
opentelemetry.trace.web.enabled->otel.springboot.web.enabledopentelemetry.trace.httpclients.enabled->otel.springboot.httpclients.enabledopentelemetry.trace.aspects.enabled->otel.springboot.aspects.enabled^^ initially I thought about
otel.instrumentation.web.enabled, etc, but was concerned that's confusing with javaagent'sotel.instrumentation.[id].enabled