Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rxjava2 NoSuchFieldError #2836

Merged
merged 2 commits into from Apr 21, 2021
Merged

Fix rxjava2 NoSuchFieldError #2836

merged 2 commits into from Apr 21, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 21, 2021 •
edited

Resolves #2819

mateuszrzeszutek
mateuszrzeszutek approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TracingConditionalSubscriber and TracingSubscriber seem to suffer from the same problem - could you update them too?
Thanks!

@laurit
Copy link
Contributor Author

laurit commented Apr 21, 2021

@mateuszrzeszutek they have a different super class where the field wasn't renamed. I guess this is because in there qs has type QueueSubscription but in BasicFuseableObserver it is QueueDisposable. Unless I missed something they should work as they are.

@mateuszrzeszutek
Copy link
Member

Oh, that's great then -- I just remembered that I had to change those two the last time I was dealing with field renames (actual -> downstream)

trask
trask approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@trask trask merged commit 3cb210a into open-telemetry:main Apr 21, 2021
@laurit laurit deleted the rxjava2-nosuchfielderror branch August 24, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io.reactivex.exceptions.UndeliverableException using v1.1.0 auto instrumentation
3 participants
@laurit @mateuszrzeszutek @trask