Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate http client tracing headers #2842

Merged
merged 7 commits into from Apr 23, 2021

Conversation

trask
Copy link
Member

@trask trask commented Apr 22, 2021

Adds a new http client test, and fixes a few http client instrumentations that did not pass:

  // this test verifies two things:
  // * the javaagent doesn't cause multiples of tracing headers to be added
  //   (TestHttpServer throws exception if there are multiples)
  // * the javaagent overwrites the existing tracing headers
  //   (so that it propagates the same trace id / span id that it reports to the backend
  //   and the trace is not broken)
  def "request with existing tracing headers"()

@trask trask changed the title Fix duplicate spring webclient tracing headers Fix duplicate http client tracing headers Apr 22, 2021
@trask trask marked this pull request as ready for review April 22, 2021 07:25
@trask trask requested a review from laurit as a code owner April 23, 2021 18:21
@trask trask merged commit 2ab92f5 into open-telemetry:main Apr 23, 2021
@trask trask deleted the spring-webclient-headers branch April 23, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants