Raise gRPC version floor to 1.6 and use new context bridge API #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
@anuraaga please update the list of supported libraries as well |
This was referenced May 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the gRPC minimum version just a little bit (still 4+ years old) and uses a newly introduced context storage API that can return a value, removing the need for the side queues. Should improve performance nicely, and unfortunately I haven't been able to reproduce the issues in #2564 but by controlling the return value which gets passed back to us more directly, I think it does fix a corner case where the reference gets changed (I can't think of a reason the app wouldn't start because it would have been a harmless log message still though FWIU). The decoupling of
current()andStorage.attach()in <=1.5 would allow them to be out of sync