Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: suppress instrumentation flag #3443

Closed

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jun 30, 2021

See open-telemetry/opentelemetry-specification#1767

Suppressing instrumentation implementations in OTel

Please note that context suppression is not really possible in client libraries as it requires dependency on instrumentation packages (to export suppress key).

@@ -21,6 +25,10 @@ class BaseTracerTest extends Specification {
@Shared
def root = Context.root()

@Shared
def ContextKey<Boolean> suppressContextKey = ContextKey.named("otel.suppress_instrumentation")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used somewhere?

Copy link
Contributor Author

@lmolkova lmolkova Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, this is a draft PR, I'm not even sure I want to proceed with it, let me close it so I don't confuse anyone.

@lmolkova lmolkova closed this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants