Improve wrapping jetty response listener #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Aug 12, 2021
mateuszrzeszutek
approved these changes
Aug 12, 2021
robododge
added a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 13, 2021
… time for request listners
|
This is great, thanks for correcting the Response listener wrapping. Now the Request listener wrapping needs the same treatment. Follow up to fix the Request-side listeners in #3833 |
robododge
added a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 13, 2021
… time for request listners
trask
pushed a commit
that referenced
this pull request
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3826
Jetty response listener can implement multiple interfaces, we need to ensure that after wrapping it implements the same interfaces as it originally did.