Add log4j2 appender javaagent instrumentation #4944
Conversation
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
| } | ||
|
|
||
| @Override | ||
| public void transform(TypeTransformer transformer) { |
There was a problem hiding this comment.
Had forgotten about the log4j appender we have. Is the reason we can't use logic from the library instrumentation to support old versions of log4j? Log transformation is much more complicated than ID injection so we shouldn't duplicate instrumentation I think if at all possible
There was a problem hiding this comment.
yeah, there are some things we can share and some we can't due to 2.0 vs 2.16. I'll send a follow-up that extracts the part(s) that are shareable so we can see if it's worth an extra module for those.
There was a problem hiding this comment.
By the way - do we need to support <2.16? :P
There was a problem hiding this comment.
let me think longer on this, I'm actually not sure...
I will update this PR to target 2.16 and share mapping code with the library instrumentation. I can always propose a separate 2.0 javaagent version later (that in addition to capturing logs, logs a warning about using a bad log4j version).
|
|
||
| testImplementation("org.awaitility:awaitility") | ||
|
|
||
| testImplementation("com.lmax:disruptor:3.4.2") |
There was a problem hiding this comment.
I added a comment to explain, it's needed for the async logger test
...emetry/javaagent/instrumentation/log4j/appender/v2_0/Log4jAppenderInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...emetry/javaagent/instrumentation/log4j/appender/v2_0/Log4jAppenderInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...pentelemetry/javaagent/instrumentation/log4j/appender/v2_0/Log4jAppenderInstrumentation.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/javaagent/instrumentation/log4j/appender/v2_0/Log4jHelper.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/javaagent/instrumentation/log4j/appender/v2_0/Log4jHelper.java
Outdated
Show resolved
Hide resolved
* log4j2 * Spotless * Target 2.16 for javaagent instrumentation and share * review feedback * Add comment * Remove unnecessary configuration * Fix comment
There's no autoconfiguration of log exporter (yet), so this instrumentation doesn't benefit end users unless they explicitly configure a logging exporter via javaagent extension (this is how the tests work).