Logback appender #4984
Merged
Logback appender #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jack-berg I just merged #4968 |
jack-berg
force-pushed
the
logback-appender
branch
from
ba555ee
to
f9484c1
Compare
jack-berg
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
This PR is now ready for review 👍 |
trask
approved these changes
Jan 4, 2022
Comment on lines
-19
to
+20
| api(platform("io.opentelemetry:opentelemetry-bom-alpha:${otelVersion}-alpha")) | ||
| api(platform("io.opentelemetry:opentelemetry-bom-alpha:${otelAlphaVersion}")) |
anuraaga
approved these changes
Jan 4, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4968. Leaving in draft until #4968 is merged.
Resolves #4947.