Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in rmi server instrumentation #5042

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jan 7, 2022

When running the app from #4982 with javaagent noticed the following exception in debug log

[otel.javaagent 2022-01-07 13:05:14:257 +0200] [main] DEBUG io.opentelemetry.javaagent.bootstrap.ExceptionLogger - Failed to handle exception in instrumentation for javax.management.remote.rmi.RMIServerImpl on jdk.internal.loader.ClassLoaders$AppClassLoader@7ad041f3
java.lang.NullPointerException: Cannot invoke "io.opentelemetry.javaagent.shaded.io.opentelemetry.context.Context.get(io.opentelemetry.javaagent.shaded.io.opentelemetry.context.ContextKey)" because "context" is null
	at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.SpanKey.fromContextOrNull(SpanKey.java:70)
	at io.opentelemetry.javaagent.shaded.instrumentation.api.instrumenter.SuppressIfSameSpanKeyStrategy.shouldSuppress(SuppressIfSameSpanKeyStrategy.java:33)
	at io.opentelemetry.javaagent.shaded.instrumentation.api.instrumenter.CompositeSuppressionStrategy.shouldSuppress(CompositeSuppressionStrategy.java:54)
	at io.opentelemetry.javaagent.shaded.instrumentation.api.instrumenter.Instrumenter.shouldStart(Instrumenter.java:138)
	at java.management.rmi/javax.management.remote.rmi.RMIServerImpl.setMBeanServer(RMIServerImpl.java:139)
	at java.management.rmi/javax.management.remote.rmi.RMIConnectorServer.start(RMIConnectorServer.java:450)
	at jdk.management.agent/sun.management.jmxremote.ConnectorBootstrap.startLocalConnectorServer(ConnectorBootstrap.java:583)
	at jdk.management.agent/jdk.internal.agent.Agent.startLocalManagementAgent(Agent.java:318)
	at jdk.management.agent/jdk.internal.agent.Agent.startAgent(Agent.java:450)
	at jdk.management.agent/jdk.internal.agent.Agent.startAgent(Agent.java:599)

@laurit laurit requested a review from a team as a code owner January 7, 2022 11:11
@trask trask merged commit d5bd3cb into open-telemetry:main Jan 7, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit laurit deleted the rmi-npe branch July 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants