Fix possible deadlock #5585
Merged
Fix possible deadlock #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Mar 16, 2022
| private static class JdkHttpServerClassLoader extends ClassLoader { | ||
|
|
||
| static { | ||
| registerAsParallelCapable(); |
trask
force-pushed
the
fix-possible-deadlock
branch
from
e14c097
to
b58b5e1
Compare
anuraaga
approved these changes
Mar 16, 2022
mateuszrzeszutek
approved these changes
Mar 16, 2022
laurit
reviewed
Mar 16, 2022
javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/AgentClassLoader.java
Outdated
Show resolved
Hide resolved
…ootstrap/AgentClassLoader.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
laurit
approved these changes
Mar 17, 2022
trask
added a commit
that referenced
this pull request
Mar 17, 2022
* Fix possible deadlock * don't break java 8 * try @laurit's idea * Update javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/AgentClassLoader.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com> Co-authored-by: Lauri Tulmin <tulmin@gmail.com> Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Fix possible deadlock * don't break java 8 * try @laurit's idea * Update javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/AgentClassLoader.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com> Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May want to consider a patch for this, I ran into deadlock locally.