Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode() #6466

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner August 12, 2022 11:06
@@ -7,24 +7,18 @@

public class ServletResponseContext<T> {
private final T response;
private final Throwable error;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 6cd79b2 into open-telemetry:main Aug 13, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
…open-telemetry#6466)

* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()

* fix liberty
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
…open-telemetry#6466)

* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()

* fix liberty
@mateuszrzeszutek mateuszrzeszutek deleted the deprecate-2arg-statusCode branch November 18, 2022 10:27
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
…open-telemetry#6466)

* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()

* fix liberty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants