Run context customizers before span start instead of after #6634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +189,13 @@ private Context doStart(Context parentContext, REQUEST request, @Nullable Instan | |||
| } | |||
There was a problem hiding this comment.
The OperationListener need to get the context with the newly created span, so that they have the proper exemplars
Comment on lines
181
to
184
| for (ContextCustomizer<? super REQUEST> contextCustomizer : contextCustomizers) { | ||
| context = contextCustomizer.onStart(context, request, attributes); |
There was a problem hiding this comment.
You should rename the first param of ContextCustomizer#onStart() to parentContext too
trask
force-pushed
the
parent-context
branch
from
02b9aec
to
7a53b3a
Compare
trask
changed the title
mateuszrzeszutek
approved these changes
Sep 21, 2022
laurit
approved these changes
Sep 21, 2022
|
I added to SIG agenda for tomorrow to get any last opinions |
|
Going ahead and merging this for next week's release |
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…metry#6634) ...so that they can have access to the parent span context, and so that their additions to the context will be visible to span processors
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…metry#6634) ...so that they can have access to the parent span context, and so that their additions to the context will be visible to span processors
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…metry#6634) ...so that they can have access to the parent span context, and so that their additions to the context will be visible to span processors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that they can have access to the parent span context, and so that their additions to the context will be visible to span processors