Add meter version to runtime metrics #6874
Conversation
| @@ -36,6 +46,74 @@ void setup() { | |||
| beans = Arrays.asList(bufferPoolBean); | |||
| } | |||
|
|
|||
| @Test | |||
| void registerObservers() { | |||
There was a problem hiding this comment.
Also adding some test coverage to make this consistent with the other runtime observers.
| @@ -50,6 +59,125 @@ void setup() { | |||
| beans = Arrays.asList(heapPoolBean, nonHeapPoolBean); | |||
| } | |||
|
|
|||
| @Test | |||
| void registerObservers() { | |||
There was a problem hiding this comment.
Also adding some test coverage to make this consistent with the other runtime observers.
...metrics/library/src/test/java/io/opentelemetry/instrumentation/runtimemetrics/ScopeUtil.java
Outdated
Show resolved
Hide resolved
|
Oh second thought, maybe we should read the version from the module's |
|
Ok you are correct. I wasn't sure how this worked behind the scenes but it looks like it relies on the It will be important that instrumentation that uses |
check out #6773, it's definitely not in an intuitive place though |
Runtime metrics doesn't include the meter version. This adds it from the utility method in the instrumentation-api `EmbeddedInstrumentationProperties.findVersion`. I know I can read the properties file for this module, but its repetitive to implement that in many places.
Runtime metrics doesn't include the meter version. This adds it from the utility method in the instrumentation-api `EmbeddedInstrumentationProperties.findVersion`. I know I can read the properties file for this module, but its repetitive to implement that in many places.
Runtime metrics doesn't include the meter version. This adds it from the utility method in the instrumentation-api
EmbeddedInstrumentationProperties.findVersion. I know I can read the properties file for this module, but its repetitive to implement that in many places.