End reactor-netty HTTP client span properly on Mono#timeout()
#6891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Oct 17, 2022
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 22, 2022
…-telemetry#6891) Calling `Mono#timeout()` with a timeout value smaller than the HTTP client timeout caused the on request/response end callbacks to be simply discarded; and the HTTP span was never finished.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…-telemetry#6891) Calling `Mono#timeout()` with a timeout value smaller than the HTTP client timeout caused the on request/response end callbacks to be simply discarded; and the HTTP span was never finished.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…-telemetry#6891) Calling `Mono#timeout()` with a timeout value smaller than the HTTP client timeout caused the on request/response end callbacks to be simply discarded; and the HTTP span was never finished.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…-telemetry#6891) Calling `Mono#timeout()` with a timeout value smaller than the HTTP client timeout caused the on request/response end callbacks to be simply discarded; and the HTTP span was never finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Mono#timeout()with a timeout value smaller than the HTTP client timeout caused the on request/response end callbacks to be simply discarded; and the HTTP span was never finished.