Revert removing the mavenCentral repo from the muzzle check plugin #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Oct 21, 2022
|
Sorry for my Inaccurate expression. Anyway, you have already got what I mean. 😄 |
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 22, 2022
…pen-telemetry#6937) Fixes open-telemetry#6932 Replaces open-telemetry#6933 @aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…pen-telemetry#6937) Fixes open-telemetry#6932 Replaces open-telemetry#6933 @aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…pen-telemetry#6937) Fixes open-telemetry#6932 Replaces open-telemetry#6933 @aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6932
Replaces #6933
@aaron-ai I finally understood what you meant in #6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository.
I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in
settings.dependencyResolutionManagementare not propagated at all (no matter whether it'safterEvaluateor not) to theproject.repositories, and that the gradle issue gradle/gradle#17295 is still valid.