Rename kafka propagation setting and clarify behavior #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
clarify-kafka-propagation-setting
branch
from
e1bbf0b
to
a121153
Compare
trask
force-pushed
the
clarify-kafka-propagation-setting
branch
from
3020c26
to
02d17e3
Compare
laurit
approved these changes
Oct 24, 2022
mateuszrzeszutek
approved these changes
Oct 24, 2022
trask
added a commit
that referenced
this pull request
Oct 24, 2022
I suspect that this was added in the original RocketMQ instrumentation because it existed in the Kafka instrumentation, and not because there was a need for it(?) See #6957 for documentation on why it is needed in Kafka
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
I suspect that this was added in the original RocketMQ instrumentation because it existed in the Kafka instrumentation, and not because there was a need for it(?) See open-telemetry#6957 for documentation on why it is needed in Kafka
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
I suspect that this was added in the original RocketMQ instrumentation because it existed in the Kafka instrumentation, and not because there was a need for it(?) See open-telemetry#6957 for documentation on why it is needed in Kafka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
otel.instrumentation.kafka.client-propagation.enabledtootel.instrumentation.kafka.producer-propagation.enabledand update code so that it only affects producer propagation, and document the original intent of the setting.