Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: run our interceptor before other interceptors #6997

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 27, 2022

Resolves #6909
If our interceptor runs before other interceptors then other interceptors replacing the request won't affect our interceptor.

@laurit laurit requested a review from a team as a code owner October 27, 2022 12:47
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit b0012b0 into open-telemetry:main Oct 27, 2022
@laurit laurit deleted the okhttp-interceptor-order branch October 28, 2022 10:25
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
…#6997)

Resolves
open-telemetry#6909
If our interceptor runs before other interceptors then other
interceptors replacing the request won't affect our interceptor.
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
…#6997)

Resolves
open-telemetry#6909
If our interceptor runs before other interceptors then other
interceptors replacing the request won't affect our interceptor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OkHttp interceptors break span parenting
3 participants