Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore presto-jdbc shaded okhttp3 connection pool. #7031

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Ignore presto-jdbc shaded okhttp3 connection pool. #7031

merged 1 commit into from
Nov 3, 2022

Conversation

breedx-splk
Copy link
Contributor

This holds onto span context if not ignored. For vanilla okhttp3 we have an explicit ignore in the OkHttp3IgnoredTypesConfigurer class, but presto-jdbc repackages okhttp3 when it shades it.

@breedx-splk breedx-splk requested a review from a team as a code owner November 2, 2022 21:14
@mateuszrzeszutek mateuszrzeszutek merged commit 6f9ca0b into open-telemetry:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@breedx-splk @trask @laurit @mateuszrzeszutek