Handle UnsupportedClassVersionError in ServiceLoader on jdk9 #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Nov 7, 2022
|
|
||
| @Override | ||
| public boolean hasNext() { | ||
| // jdk9 and newer throw UnsupportedClassVersionError in hasNext() |
There was a problem hiding this comment.
oh interesting, so we would have run into this problem on Java 11 if we introduced Java 17-only instrumentation
do you know if the underlying iterator will move on item hasNext when it throws exception, so that we will continue iterating over it from that point?
There was a problem hiding this comment.
I tested it manually and believe that hasNext will move to the next element on exception. Relevant code is in
https://github.com/openjdk/jdk11u/blob/b928a88fd564fab88f00086a62c0695ed5cc9353/src/java.base/share/classes/java/util/ServiceLoader.java#L1181 pending iterator is advanced before Class.forName
mateuszrzeszutek
approved these changes
Nov 8, 2022
trask
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves the issue described in #7084