Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/add additionalServerExtractors #7155

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Enhancement/add additionalServerExtractors #7155

merged 5 commits into from
Nov 15, 2022

Conversation

arik-dig
Copy link
Contributor

@arik-dig arik-dig commented Nov 14, 2022

fixes issue #7153

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@arik-dig
Copy link
Contributor Author

@trask can you please help?
I don't think its related to this PR, but it seems like Github job testLatestDeps is failing with:

FAILURE: Build failed with an exception.

  • What went wrong:
    Could not determine the dependencies of task ':instrumentation:aws-sdk:aws-sdk-1.11:library:test'.

Could not resolve all task dependencies for configuration ':instrumentation:aws-sdk:aws-sdk-1.11:library:testRuntimeClasspath'.
Could not resolve com.amazonaws:aws-java-sdk-sqs:latest.release.
Required by:
project :instrumentation:aws-sdk:aws-sdk-1.11:library
> Failed to list versions for com.amazonaws:aws-java-sdk-sqs.
> Unable to load Maven meta-data from https://repo.maven.apache.org/maven2/com/amazonaws/aws-java-sdk-sqs/maven-metadata.xml.
> Could not HEAD 'https://repo.maven.apache.org/maven2/com/amazonaws/aws-java-sdk-sqs/maven-metadata.xml'.
> Connect to repo.maven.apache.org:443 [repo.maven.apache.org/146.75.28.215] failed: Connect timed out

here's the link: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/3460309292/jobs/5776722669

@mateuszrzeszutek
Copy link
Member

@trask can you please help? I don't think its related to this PR, but it seems like Github job testLatestDeps is failing with:

It looks like there were some maven/network hiccups; we've been having lots of these recently. I reran the failing jobs, 🤞 that it passes this time.

@arik-dig
Copy link
Contributor Author

arik-dig commented Nov 14, 2022

@trask can you please help? I don't think its related to this PR, but it seems like Github job testLatestDeps is failing with:

It looks like there were some maven/network hiccups; we've been having lots of these recently. I reran the failing jobs, 🤞 that it passes this time.

@mateuszrzeszutek, I tried to rerun and now it fails on something else

* What went wrong:
Could not determine the dependencies of task ':instrumentation:jsp-2.3:javaagent:test'.
> Could not resolve all task dependencies for configuration ':instrumentation:jsp-2.3:javaagent:testRuntimeClasspath'.
   > Could not resolve org.apache.tomcat.embed:tomcat-embed-core:latest.release.
     Required by:
         project :instrumentation:jsp-2.3:javaagent
      > Cannot find a version of 'org.apache.tomcat.embed:tomcat-embed-core' that satisfies the version constraints:
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-core:latest.release'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:10.1.2' (runtime) --> 'org.apache.tomcat.embed:tomcat-embed-core:10.1.2'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-core:{strictly 9.+}'

   > Could not resolve org.apache.tomcat.embed:tomcat-embed-jasper:latest.release.
     Required by:
         project :instrumentation:jsp-2.3:javaagent
      > Cannot find a version of 'org.apache.tomcat.embed:tomcat-embed-jasper' that satisfies the version constraints:
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:latest.release'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:{strictly 9.+}'

   > Could not resolve org.apache.tomcat.embed:tomcat-embed-core:{strictly 9.+}.
     Required by:
         project :instrumentation:jsp-2.3:javaagent
      > Cannot find a version of 'org.apache.tomcat.embed:tomcat-embed-core' that satisfies the version constraints:
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-core:latest.release'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:10.1.2' (runtime) --> 'org.apache.tomcat.embed:tomcat-embed-core:10.1.2'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-core:{strictly 9.+}'

   > Could not resolve org.apache.tomcat.embed:tomcat-embed-jasper:{strictly 9.+}.
     Required by:
         project :instrumentation:jsp-2.3:javaagent
      > Cannot find a version of 'org.apache.tomcat.embed:tomcat-embed-jasper' that satisfies the version constraints:
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:latest.release'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:{strictly 9.+}'

   > Could not resolve org.apache.tomcat.embed:tomcat-embed-core:10.1.2.
     Required by:
         project :instrumentation:jsp-2.3:javaagent > org.apache.tomcat.embed:tomcat-embed-jasper:10.1.2
      > Cannot find a version of 'org.apache.tomcat.embed:tomcat-embed-core' that satisfies the version constraints:
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-core:latest.release'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-jasper:10.1.2' (runtime) --> 'org.apache.tomcat.embed:tomcat-embed-core:10.1.2'
           Dependency path 'io.opentelemetry.dummy.jsp-2.3:javaagent:1.20.0-alpha-SNAPSHOT' --> 'org.apache.tomcat.embed:tomcat-embed-core:{strictly 9.+}'

https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/3462240877/jobs/5780874426

any ideas?

@arik-dig arik-dig marked this pull request as ready for review November 14, 2022 19:14
@arik-dig arik-dig requested a review from a team as a code owner November 14, 2022 19:14
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @arik-dig!

@trask
Copy link
Member

trask commented Nov 15, 2022

@arik-dig heads up I merged main into your branch to fix the CI failures

@arik-dig
Copy link
Contributor Author

@trask, @mateuszrzeszutek seems like the build passed successfully, thanks.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/3467495467

however I cannot merge back to origin main, can you please do it, or give me the permission to do so?

@mateuszrzeszutek mateuszrzeszutek merged commit deebf6d into open-telemetry:main Nov 15, 2022
@mateuszrzeszutek
Copy link
Member

Merged. Thanks @arik-dig !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants