Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7274 Reduce mem consumption from reference queue #7275

Closed
wants to merge 1 commit into from

Conversation

Iapetus999
Copy link

#7274

An alternative would be to create a env flag for this.

open-telemetry#7274

An alternative would be to create a env flag for this.
@Iapetus999 Iapetus999 requested a review from a team as a code owner November 22, 2022 20:02
@linux-foundation-easycla
Copy link

CLA Not Signed

@trask
Copy link
Member

trask commented Nov 22, 2022

hi @lapetus999! check out #6240, I believe it's addressing the same issue, and probably we should get that merged?

@Iapetus999
Copy link
Author

Yeah we've been having a lot of problems with this. I'm okay with closing this as a dupe of the other PR. What needs to be done to get the other PR merged?

@trask
Copy link
Member

trask commented Nov 22, 2022

Yeah we've been having a lot of problems with this. I'm okay with closing this as a dupe of the other PR. What needs to be done to get the other PR merged?

great, since you have an active repro, can you build and test that PR to confirm things look good for you?

@Iapetus999
Copy link
Author

Since the issue only repros in Production, I won't be able to test it until next week (holiday code freeze). I am running this PR and it's looking good.

@trask
Copy link
Member

trask commented Nov 22, 2022

Since the issue only repros in Production, I won't be able to test it until next week (holiday code freeze)

that would be great, the next release (1.21.0) is targeted for December 14

@trask
Copy link
Member

trask commented Nov 23, 2022

I think we can close this, now that #6240 has been merged, thx for raising this!

It would still be really helpful if you could report back your findings after you have a chance to test the latest snapshot build: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CONTRIBUTING.md#snapshot-builds

@trask trask closed this Nov 23, 2022
@Iapetus999
Copy link
Author

Hi @trask
We've had this running in Production for a few days now and it's looking good.
I grabbed opentelemetry-javaagent-1.21.0-20221206.081659-86.jar

@trask
Copy link
Member

trask commented Dec 12, 2022

@Iapetus999 thx! 1.21.0 release should be out in a couple of days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants