Refactored servlet instrumentation and dependents #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydin
requested review from
jkwatson,
safris,
trask and
tylerbenson
as code owners
|
Thx! Can you check out the It looks like it's in You can run the failed muzzle locally for this one module with:
|
|
Oh... The muzzle tests aren't part of the regular test/check battery of tests? Have we documented somewhere what the test sequence should be before you issue a PR? |
|
I think |
trask
reviewed
Jan 21, 2020
...main/java/io/opentelemetry/auto/instrumentation/reactor/core/FluxAndMonoInstrumentation.java
Outdated
Show resolved
Hide resolved
...ain/java8/io/opentelemetry/auto/instrumentation/reactor/core/FluxAndMonoSubscribeAdvice.java
Outdated
Show resolved
Hide resolved
...ain/java8/io/opentelemetry/auto/instrumentation/reactor/core/FluxAndMonoSubscribeAdvice.java
Outdated
Show resolved
Hide resolved
...rc/main/java8/io/opentelemetry/auto/instrumentation/reactor/core/ReactorCoreAdviceUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java8/io/opentelemetry/auto/instrumentation/reactor/core/ReactorCoreDecorator.java
Show resolved
Hide resolved
...ava8/io/opentelemetry/auto/instrumentation/springwebflux/server/DispatcherHandlerAdvice.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/auto/instrumentation/springweb/DispatcherServletInstrumentation.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/auto/instrumentation/springweb/HandlerAdapterInstrumentation.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/auto/instrumentation/springweb/HandlerAdapterInstrumentation.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/auto/instrumentation/springweb/DispatcherServletInstrumentation.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 22, 2020
...ain/java8/io/opentelemetry/auto/instrumentation/reactor/core/FluxAndMonoSubscribeAdvice.java
Outdated
Show resolved
Hide resolved
...t/request-2/src/main/java/io/opentelemetry/auto/instrumentation/servlet2/Servlet2Advice.java
Outdated
Show resolved
Hide resolved
...a8/io/opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseMono.java
Outdated
Show resolved
Hide resolved
...opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseSubscriber.java
Outdated
Show resolved
Hide resolved
...opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseSubscriber.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/auto/instrumentation/springweb/DispatcherServletInstrumentation.java
Outdated
Show resolved
Hide resolved
…opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseMono.java Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
…opentelemetry/auto/instrumentation/reactor/core/FluxAndMonoSubscribeAdvice.java Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
…opentelemetry/auto/instrumentation/springweb/DispatcherServletInstrumentation.java Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
…opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseSubscriber.java Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
trask
reviewed
Jan 22, 2020
...t/request-2/src/main/java/io/opentelemetry/auto/instrumentation/servlet2/Servlet2Advice.java
Outdated
Show resolved
Hide resolved
...opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseSubscriber.java
Outdated
Show resolved
Hide resolved
…opentelemetry/auto/instrumentation/servlet2/Servlet2Advice.java Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
…opentelemetry/auto/instrumentation/springwebflux/client/TracingClientResponseSubscriber.java Co-Authored-By: Trask Stalnaker <trask.stalnaker@gmail.com>
55 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70 (servlet instrumentation needs refactoring)
Closes #68 (spring-* needs refactoring)
Added some log.debug statements to ListWriter to allow viewing of spans created and closed.