Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade application.io.opentelemetry in agent extension class loader #7519

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Shade application.io.opentelemetry in agent extension class loader #7519

merged 2 commits into from
Jan 12, 2023

Conversation

wallezhang
Copy link
Contributor

Related issue #7518

Add shade rule application.io.opentelemetry in io.opentelemetry.javaagent.tooling.RemappingUrlConnection class.

Closed #7518

@wallezhang wallezhang requested a review from a team as a code owner January 6, 2023 04:09
@wallezhang
Copy link
Contributor Author

@mateuszrzeszutek Hi, this PR is related to the discussion #7485. Could you help to take a code review?

mateuszrzeszutek
mateuszrzeszutek reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/RemappingUrlConnection.java Outdated Show resolved Hide resolved
@wallezhang
Refactor: Remove unnecessary shade rules
08e49e2 
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
mateuszrzeszutek
mateuszrzeszutek approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trask trask merged commit 13be0e2 into open-telemetry:main Jan 12, 2023
@wallezhang wallezhang deleted the fix-extension-classloader-remapping branch January 12, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shade application.io.opentelemetry when agent extension loaded
3 participants
@wallezhang @trask @mateuszrzeszutek