Add type matching benchmark #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson and
tylerbenson
as code owners
anuraaga
approved these changes
Jul 23, 2020
benchmark/benchmark.gradle
Outdated
| @@ -22,10 +25,16 @@ jmh { | |||
| fork = 1 // How many times to forks a single benchmark. Use 0 to disable forking altogether | |||
| // jvmArgs += ["-XX:+UnlockDiagnosticVMOptions", "-XX:+DebugNonSafepoints", "-XX:StartFlightRecording=delay=5s,dumponexit=true,name=jmh-benchmark,filename=$rootDir/benchmark/build/reports/jmh/jmh-benchmark.jfr"] | |||
| // jvmArgs += ["-agentpath:$rootDir/benchmark/src/jmh/resources/libasyncProfiler.so=start,collapsed,file=$rootDir/benchmark/build/reports/jmh/profiler.txt"] | |||
| failOnError = true // Should JMH fail immediately if any benchmark had experienced the unrecoverable error? | |||
|
|
|||
| // uncomment to use for TypeMatchingBenchmark | |||
There was a problem hiding this comment.
Is it worth having a separate Gradle project?
There was a problem hiding this comment.
I just tried this, but the jmh task seems different from normal gradle tasks(?): https://github.com/melix/jmh-gradle-plugin/blob/master/src/main/groovy/me/champeau/gradle/JMHTask.java#L32
and so I run into this problem:
There was a problem hiding this comment.
for now, I modeled it similar to existing benchmarks, and I added #782
iNikem
reviewed
Jul 23, 2020
benchmark/benchmark.gradle
Outdated
| @@ -22,10 +25,16 @@ jmh { | |||
| fork = 1 // How many times to forks a single benchmark. Use 0 to disable forking altogether | |||
| // jvmArgs += ["-XX:+UnlockDiagnosticVMOptions", "-XX:+DebugNonSafepoints", "-XX:StartFlightRecording=delay=5s,dumponexit=true,name=jmh-benchmark,filename=$rootDir/benchmark/build/reports/jmh/jmh-benchmark.jfr"] | |||
| // jvmArgs += ["-agentpath:$rootDir/benchmark/src/jmh/resources/libasyncProfiler.so=start,collapsed,file=$rootDir/benchmark/build/reports/jmh/profiler.txt"] | |||
| failOnError = true // Should JMH fail immediately if any benchmark had experienced the unrecoverable error? | |||
|
|
|||
| // uncomment to use for TypeMatchingBenchmark | |||
benchmark/src/jmh/java/io/opentelemetry/benchmark/TypeMatchingBenchmark.java
Outdated
Show resolved
Hide resolved
|
@trask do you want to address my comments and will merge? |
|
Yes, I do want to address your comments, they are good, just haven't got to it yet |
anuraaga
approved these changes
Jul 25, 2020
benchmark/src/jmh/java/io/opentelemetry/benchmark/TypeMatchingBenchmark.java
Outdated
Show resolved
Hide resolved
benchmark/src/jmh/java/io/opentelemetry/benchmark/TypeMatchingBenchmark.java
Outdated
Show resolved
Hide resolved
iNikem
approved these changes
Jul 25, 2020
benchmark/src/jmh/java/io/opentelemetry/benchmark/TypeMatchingBenchmark.java
Outdated
Show resolved
Hide resolved
benchmark/src/jmh/java/io/opentelemetry/benchmark/TypeMatchingBenchmark.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this to benchmark the change discussed in #646 (comment), and the benchmark seems useful to keep around (and probably improve).