Add exporter data classes for experimental profiling signal type.

Changes addressing code review comments.
open-telemetry · May 17, 2024 · bda144f · bda144f
1 parent a84e2f9
commit bda144f
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 38 deletions.
diff --git a/...ers/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/FunctionData.java b/...ers/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/FunctionData.java
@@ -15,14 +15,6 @@
 @Immutable
 public interface FunctionData {
 
-  /**
-   * Unique nonzero id for the function.
-   *
-   * @deprecated retained only for pprof compatibility.
-   */
-  @Deprecated
-  long getId();
-
   /** Name of the function, in human-readable form if available. Index into string table. */
   long getNameIndex();
 

diff --git a/...ers/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/LocationData.java b/...ers/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/LocationData.java
@@ -16,15 +16,6 @@
 @Immutable
 public interface LocationData {
 
-  /**
-   * Unique nonzero id for the location. Could use instruction addresses or any integer sequence as
-   * ids.
-   *
-   * @deprecated retained only for pprof compatibility.
-   */
-  @Deprecated
-  long getId();
-
   /**
    * The index of the corresponding profile.Mapping for this location. It can be unset if the
    * mapping is unknown or not applicable for this profile type.

diff --git a/...ters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/MappingData.java b/...ters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/MappingData.java
@@ -16,14 +16,6 @@
 @Immutable
 public interface MappingData {
 
-  /**
-   * Unique nonzero id for the mapping.
-   *
-   * @deprecated retained only for pprof compatibility.
-   */
-  @Deprecated
-  long getId();
-
   /** Address at which the binary (or DLL) is loaded into memory. */
   long getMemoryStart();
 

diff --git a/...rters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/SampleData.java b/...rters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/SampleData.java
@@ -18,15 +18,6 @@
 @Immutable
 public interface SampleData {
 
-  /**
-   * The indices recorded here correspond to locations in Profile.location. The leaf is at
-   * location_index[0].
-   *
-   * @deprecated superseded by locations_start_index / locations_length
-   */
-  @Deprecated
-  List<Long> getLocationIndices();
-
   /**
    * locationsStartIndex along with locationsLength refers to a slice of locations in
    * Profile.location. Supersedes locationIndices.
@@ -50,10 +41,6 @@ public interface SampleData {
    */
   List<Long> getValues();
 
-  /** Additional context for this sample. It can include thread id, allocation size, etc. */
-  @Deprecated
-  List<LabelData> getLabels();
-
   /** References to attributes in Profile.attribute_table. */
   List<Long> getAttributes();