Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of Baggage.toBuilder seems tricky to understand #2784

Closed
bogdandrutu opened this issue Feb 9, 2021 · 3 comments · Fixed by #2838
Closed

Behavior of Baggage.toBuilder seems tricky to understand #2784

bogdandrutu opened this issue Feb 9, 2021 · 3 comments · Fixed by #2838
Milestone

Comments

@bogdandrutu
Copy link
Member

The current behavior of the Baggage.toBuilder seems a bit tricky when it is combine with a parent. I am not sure based on the javadoc if I can understand the behavior (without looking at the code).

So I suggest to improve the javadoc for this method and clearly explain what would be the result when a parent is set, how conflicts (duplicate keys are resolved).

PS: @jkwatson there is always the option to remove this method, used only in tests and benchmarks :)))

@bogdandrutu bogdandrutu added the Bug Something isn't working label Feb 9, 2021
@jkwatson
Copy link
Contributor

jkwatson commented Feb 9, 2021

PS: @jkwatson there is always the option to remove this method, used only in tests and benchmarks :)))

We might be able to get rid of all the APIs! ;)

@bogdandrutu
Copy link
Member Author

Not all, but half :))

@bogdandrutu
Copy link
Member Author

To be clear: I think this issue is just to improve documentation and clarify the behavior

@bogdandrutu bogdandrutu added documentation and removed Bug Something isn't working labels Feb 9, 2021
@bogdandrutu bogdandrutu changed the title Baggage.toBuilder seems tricky to understand Behavior of Baggage.toBuilder seems tricky to understand Feb 9, 2021
@anuraaga anuraaga added this to the 1.0 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants