Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Remove BaggageBuilder.setParent / setNoParent #2838

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Feb 17, 2021

Instead, expect Baggage.current().toBuilder()

Fixes #2784

@anuraaga anuraaga changed the title Remove BaggageBuilder.setParent / setNoParent [Breaking Change] Remove BaggageBuilder.setParent / setNoParent Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #2838 (cfed803) into main (43f1ecf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2838   +/-   ##
=========================================
  Coverage     89.78%   89.79%           
+ Complexity     2642     2641    -1     
=========================================
  Files           308      308           
  Lines          8458     8436   -22     
  Branches        855      852    -3     
=========================================
- Hits           7594     7575   -19     
+ Misses          602      599    -3     
  Partials        262      262           
Impacted Files Coverage Δ Complexity Δ
...a/io/opentelemetry/api/baggage/BaggageBuilder.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...io/opentelemetry/api/baggage/ImmutableBaggage.java 100.00% <100.00%> (+10.20%) 15.00 <1.00> (ø)
...opentelemetry/opentracingshim/SpanContextShim.java 91.30% <100.00%> (-0.37%) 10.00 <1.00> (ø)
...ntelemetry/exporter/zipkin/ZipkinSpanExporter.java 86.27% <0.00%> (-1.97%) 33.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f1ecf...cfed803. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bogdandrutu bogdandrutu merged commit fa15e8b into open-telemetry:main Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior of Baggage.toBuilder seems tricky to understand
3 participants