Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opentelemetry-extension-aws to contrib #4831

Closed
jack-berg opened this issue Oct 7, 2022 · 3 comments · Fixed by #4945
Closed

Move opentelemetry-extension-aws to contrib #4831

jack-berg opened this issue Oct 7, 2022 · 3 comments · Fixed by #4945
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

This is the last remaining item of #4661. Splitting it out to avoid the noise of the larger conversation.

Here's the last comment about opentelemetry-extension-aws:

The opentelemetry-extension-aws extension. As mentioned #4661 (comment), we can leave it where it is as an exception. However, if we don't need to continue publishing stable artifacts forever, it seems like quite an odd exception. In that case, would be better to move it to opentelemetry-java-contrib and include it in the proposed opentelemetry-javaagent-contrib-{version}.jar.

We've decided we don't need to publish stable artifacts forever. The only reason not to move it to opentelemetry-java-contrib today is because the otel java agent still includes it. Here are the options I see:

  1. Move to contrib. Have the otel java agent depend on the contrib artifact 1 minor version behind the latest.
  2. Move to contrib. Remove the dependency from the otel java agent. Publish a contrib version of the java agent which depends on it.
  3. Move to contrib. Remove the dependency on the otel java agent. Require users to include / enable it via the java agent extension mechanism. (Note, users already have to do this today to utilize aws resource providers.)
  4. Keep it here as an exception to the general rule that vendor specific protools must not be maintained as part of core repositories. Note, the argument to keep it here is pretty flimsy now that we've established we don't need to keep publishing stable artifacts forever.

I like options 1 and 3 the best. Option 2 makes sense if we foresee a growing number of instrumentations in contrib. I'm against option 4.

@jack-berg jack-berg added the Feature Request Suggest an idea for this project label Oct 7, 2022
@mateuszrzeszutek
Copy link
Member

There are several instrumentations that reference the AwsXrayPropagator class: AWS SDK, AWS lambdas, Apache Camel, and the Spring Boot Starter. Option 1 requires the least amount of changes, and I think I prefer it the most. Options 2 & 3 will require us to move these instrumentations to contrib as well.

@trask
Copy link
Member

trask commented Oct 11, 2022

Option 1 sounds good to me also. We'll probably figure out the general instrumentation vs contrib story eventually, but not today 😄.

@jack-berg
Copy link
Member Author

@jkwatson if you agree the first option I'll go ahead and get started on that by copying the code to contrib and deprecating it here.

sdelamo added a commit to micronaut-projects/micronaut-tracing that referenced this issue Apr 15, 2024
It replaces :

```
io.opentelemetry:opentelemetry-sdk-extension-aws
```

with:

```
io.opentelemetry.contrib:opentelemetry-aws-resources
```

and:

```
io.opentelemetry.contrib:opentelemetry-aws-xray-propagator
```

see:

open-telemetry/opentelemetry-java#4945
open-telemetry/opentelemetry-java#4831

it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha

> Version 1.34.0 targets the OpenTelemetry SDK 1.34.0.

As we are in 1.36.0 I think this is the correct version to use for it.
sdelamo added a commit to micronaut-projects/micronaut-tracing that referenced this issue Apr 15, 2024
* test: adds a test-suite-xray module

This adds a test-suite-xray module to verify the following dependencies are resolvables without specifying the version:

io.opentelemetry:opentelemetry-exporter-otlp
io.opentelemetry:opentelemetry-extension-aws
io.opentelemetry.instrumentation:opentelemetry-aws-sdk-2.2

* bug: replace opentelemetry-sdk-extension-aws mentions

It replaces :

```
io.opentelemetry:opentelemetry-sdk-extension-aws
```

with:

```
io.opentelemetry.contrib:opentelemetry-aws-resources
```

and:

```
io.opentelemetry.contrib:opentelemetry-aws-xray-propagator
```

see:

open-telemetry/opentelemetry-java#4945
open-telemetry/opentelemetry-java#4831

it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha

> Version 1.34.0 targets the OpenTelemetry SDK 1.34.0.

As we are in 1.36.0 I think this is the correct version to use for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants